crytic/slither

Inheritance printer adds unnecessary carriage return

Open

#1,835 创建于 2023年4月12日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)Python (4,769 star) (886 fork)batch import
good first issuehelp wanted

描述

% cat test.sol

pragma solidity >= 0.8.19;

interface IFoo{}

contract Foo is IFoo {}

abstract contract Bar is Foo {}

interface IBaz{}

contract Baz is Bar, IBaz{}

% slither test.sol --print inheritance

+ Baz
 -> Bar, IBaz
, [Foo, IFoo]

It looks like we added unnecessary carriage return to the output at some point

贡献者指南

技术栈
python
领域
cli
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic PythonFamiliarity with Slither's printer modules
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
Investigate the inheritance printer output formatting in Slither's source code, likely in a file related to inheritance printing. Look for where the arrow and newline are added after 'Bar, IBaz' to remove the unnecessary carriage return. Refer to the linked issue and comments for context, and test with the provided Solidity sample.