crytic/slither

Improve 1346 to make it more efficient

Open

#1,570 创建于 2023年1月9日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)Python (4,769 star) (886 fork)batch import
enhancementhelp wanted

描述

https://github.com/crytic/slither/pull/1346 is a nice addition, which gives us fundamental features to do structure packing optimisations.

However it has a couple of drawback. For example packing storage variables might lead to more costly execution because of the additional opcode cost.

We could improve the detector to add a couple of heuristics. One example that comes to mind is to use https://eips.ethereum.org/EIPS/eip-2929#sstore-changes, and to pack together variables that are read within the same transaction.

We could make it a tool instead of a detector, and propose different scenario as a result, ie:

  • To optimize the run of contract.function1 pack together ..
  • To optimize the run of contract.function2 pack together ..

Having a tool would allow us additional fine tuning and flags.

贡献者指南

技术栈
python
领域
toolingperformance
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Solidity storage layoutSlither detector frameworkEIP 2929
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
25
研究方向
Examine the existing detector from PR #1346 to understand its current behavior and limitations. Study EIP 2929 to design heuristics for packing storage variables that are read in the same transaction. Propose converting the detector into a tool that outputs optimization scenarios for specific functions. Identify the relevant module files in the Slither codebase (e.g., under 'slither/detectors/') and outline a plan for implementation.