Slither claims an upgradeTo function is exposed when it (likely?) is not · crytic/slither#1136

(9 评论) (0 反应) (0 负责人)Python (4,769 star) (886 fork)batch import

enhancementgood first issue

描述

Describe the issue:

When running Slither on this UUPS upgradeable contract](https://github.com/OpenQDev/OpenQ-Contracts/blob/development/contracts/OpenQ/Implementations/OpenQV0.sol), it triggers the unprotected-upgradeable-contract critical warning as shown below:

However, the latest OpenZeppelin UUPSUpgradeable.sol does indeed protect its upgradeTo method with both onlyProxy, as well as an optional _authorizeUpgrade method which I have onlyOwnered as seen here.

So I believe that only an owner calling via the proxy will be able to call upgradeTo....unless I'm wrong and missing something and Slither is doing its wonderful job 😅.

Code example to reproduce the issue:

git clone https://github.com/OpenQDev/OpenQ-Contracts.git cd OpenQ-Contracts solc-select use 0.8.12 slither . --exclude-dependencies

Version:

slither 0.8.2

Relevant log output:

OpenQV0 (contracts/OpenQ/Implementations/OpenQV0.sol#18-254) is an upgradeable contract that does not protect its initiliaze functions: OpenQV0.initialize(address) (contracts/OpenQ/Implementations/OpenQV0.sol#30-35). Anyone can delete the contract with: UUPSUpgradeable.upgradeTo(address) (node_modules/@openzeppelin/contracts-upgradeable/proxy/utils/UUPSUpgradeable.sol#72-75)UUPSUpgradeable.upgradeToAndCall(address,bytes) (node_modules/@openzeppelin/contracts-upgradeable/proxy/utils/UUPSUpgradeable.sol#85-88)Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#unprotected-upgradeable-contract

贡献者指南

技术栈: python
领域: securitytesting
议题类型: bug
难度: 3
预计时间: half day
活动状态: stale
清晰度: clear
前置要求: Basic understanding of SlitherFamiliarity with Solidity upgradeable contractsKnowledge of OpenZeppelin UUPS pattern
新手友好度: 40
研究方向: Investigate Slither's 'unprotected upgradeable contract' detector logic in the source code (likely in the detectors module). Look at the referenced OpenZeppelin UUPSUpgradeable.sol to confirm that upgradeTo is protected by onlyProxy and the optional authorizeUpgrade. Check the issue comments for any maintainer responses or additional context. Then determine if the false positive is due to Slither not recognizing the onlyProxy modifier or the authorizeUpgrade override.