corejavascript/typeahead.js

Deduplication of common/utils

Open

#165 创建于 2017年10月10日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)JavaScript (956 star) (232 fork)batch import
enhancementhelp wanted

描述

Up until version 0.10.x, common/utils was shared by Bloodhound & Typeahead.

From version 0.11.x onwards, Bloodhound & Typeahead are defined as UMD modules, and each module has its own copy of common/utils. This results in unnecessary redundancy / bloat.

There's several solutions for this. Personally, I lean towards one of these options :

  • Put common/utils into a third module that is used as a dependency by both Bloodhound & Typeahead
  • Replace common/utils by two distinct util classes that are no longer shared between Bloodhound & Typeahead

What do you guys think about this?

贡献者指南

技术栈
javascript
领域
frontend
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptUnderstanding of UMD modulesFamiliarity with the repository structure
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The issue proposes deduplicating 'common/utils' which is currently copied in both Bloodhound and Typeahead modules. Investigate the 'common/utils' directory in the repository to understand the shared utilities. Then evaluate the two proposed solutions: creating a third shared module or splitting the utilities into distinct classes. Look at the existing module definitions in the codebase to see how dependencies are managed.