corejavascript/typeahead.js

autocomplete() should trigger autocomplete event even when text already matches

Open

#132 创建于 2017年3月15日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)JavaScript (956 star) (232 fork)batch import
enhancementhelp wanted

描述

Currently, autocomplete() doesn't trigger the autocomplete event if the input text matches the given $selectable. Why should it, if autocompletion won't change the text?

Because there may be other data attached to the typeahead choice which is extracted by downstream logic listening for the event.

Instead of

      isValid = data && query !== data.val;
      if (isValid && !this.eventBus.before('autocomplete', data.obj, data.dataset)) {

it should be just

      if (data && !this.eventBus.before('autocomplete', data.obj, data.dataset)) {

贡献者指南

技术栈
javascript
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptEvent systemTypeahead library
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
Review the autocomplete() method in src/typeahead/typeahead.js around line 371. Understand the current condition that prevents event dispatch when query matches. Implement the suggested change to remove the query !== data.val check. Ensure that the autocomplete event is emitted even when text matches, so that downstream listeners can access the data object.