conventional-changelog/commitlint

Error when working from within a branch worktree

已关闭

#787 创建于 2019年9月13日

在 GitHub 查看贡献者指南
 (13 条评论) (0 个反应) (0 位负责人)TypeScript (896 个派生)batch import
bughelp wanted

仓库指标

星标
 (15,497 个星标)
PR 合并指标
 (平均合并 12小时 56分钟) (30 天内合并 52 个 PR)

描述

When trying to run commitlint from within a branch worktree directory, I get the following error: could not find git root from undefined

Expected Behavior

The operation should succeed without error.

Current Behavior

The operation errors with could not find git root from undefined

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Steps to Reproduce (for bugs)

  1. Checkout a repo
  2. Checkout a different branch into a separate folder via worktree: git worktree add -b my-branch ../my-branch
  3. CD into the branch folder
  4. Make some changers
  5. Try to commit

Your Environment

Executable Version
commitlint --version 8.1.0
git --version git version 2.20.1.windows.1
node --version v10.14.1

贡献者指南

研究方向
Investigate how commitlint resolves the git root. The error suggests that the git root detection returns undefined in worktree directories. Check the source code in the CLI package, likely in the `@commitlint/cli` or `@commitlint/load` module, where `git rev parse show toplevel` is called. Consider using ` git common dir` or ` path format` to handle worktrees. Refer to linked PRs or comments for prior discussion. Also examine existing tests for git root resolution.
技术栈
typescript
领域
cli
议题类型
缺陷
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
半天
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
较久未更新
清晰度议题是否清楚说明期望改动、验收标准和下一步。
清晰
前置要求
git worktree conceptcommitlint internalsTypeScript
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60