ContribfestGood First Issuebugweektriagedvolunteers-wanted
仓库指标
- Star
- (31,686 star)
- PR 合并指标
- (30 天内没有已合并 PR)
描述
With the upcoming golangci-lint bump to v2.6.0 in https://github.com/containers/podman/pull/27473 , the lint check fails on seccomp deprecations like so:
+ ./bin/golangci-lint run --build-tags=apparmor,seccomp,selinux
pkg/specgen/generate/kube/seccomp.go:40:30: SA1019: v1.SeccompContainerAnnotationKeyPrefix is deprecated: set a container security context `seccompProfile` field. (staticcheck)
if prefixAndCtr[0]+"/" != v1.SeccompContainerAnnotationKeyPrefix {
^
pkg/specgen/generate/kube/seccomp.go:56:33: SA1019: v1.SeccompPodAnnotationKey is deprecated: set a pod security context `seccompProfile` field. (staticcheck)
podSeccomp, ok := annotations[v1.SeccompPodAnnotationKey]
^
pkg/specgen/generate/kube/seccomp.go:73:7: SA1019: v1.DeprecatedSeccompProfileDockerDefault is deprecated: set a pod or container security context `seccompProfile` of type "RuntimeDefault" instead. (staticcheck)
case v1.DeprecatedSeccompProfileDockerDefault:
^
pkg/specgen/generate/kube/seccomp.go:75:7: SA1019: v1.SeccompProfileRuntimeDefault is deprecated: set a pod or container security context `seccompProfile` of type "RuntimeDefault" instead. (staticcheck)
case v1.SeccompProfileRuntimeDefault:
^
#27473 will proceed with marking those as nolint and a pointer here, so someone more knowledgeable with seccomp could pick this up.