combust/mleap

Reenable LDA parity spec

Open

#169 创建于 2017年4月6日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)Scala (1,461 star) (312 fork)batch import
bughelp wanted

描述

LDA uses a random sampling to score data. This causes slightly different values to to be generated between each run, which makes testing outright equality of tensors a no-go for the parity spec.

We are temporarily disabling the LDA parity spec in favor of fixing tensor equality and will reenable the parity spec using lighter equality restrictions at a later time before the 0.7.0 release.

See the tensor equality issue here: https://github.com/combust/mleap/pull/156

贡献者指南

技术栈
scala
领域
machine learningtesting
议题类型
test
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ScalaMLeap basicstesting
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Review PR #156 for the tensor equality fix. Locate the LDA parity spec file (likely LdaParitySpec.scala) and modify the test assertions to use approximate equality instead of exact tensor equality. Consider using a tolerance based comparison to account for random sampling variation. Re enable the spec before the 0.7.0 release.