codex-team/editor.js

Bug: clicking outside of an editor should clear currentBlock (call dropPointer) even if selection was inside of editor before the click

Open

#2,643 创建于 2024年2月29日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)TypeScript (26,602 star) (1,985 fork)batch import
buggood first issue

描述

Describe a bug.

Steps to reproduce:

  1. Go to example_dev.html
  2. Click on somewhere outside of the editor
  3. Press '/'

Expected behavior: Toolbox shouldn't be opened, because I've already went out of the editor by clicking outside

Actual: Toolbox is still opened because we haven't cleared currentBlock

Device, Browser, OS: Any

Editor.js version: 2.29.1

贡献者指南

技术栈
typescriptjavascripthtmlcss
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic understanding of DOM eventsfamiliarity with block style editors
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
The bug is that clicking outside the editor does not clear currentBlock, causing the toolbox to open unexpectedly. Look at the editor's click event handlers, likely in the core module (e.g., core.js or similar). The fix likely involves adding a document click listener that calls dropPointer() when clicking outside the editor area. Check if there are any existing event listeners that handle outside clicks and ensure they properly reset currentBlock.
Bug: clicking outside of an editor should clear currentBlock (call dropPointer) even if selection was inside of editor before the click · codex-team/editor.js#2643 | Good First Issue