codeceptjs/CodeceptJS

[feature-request] REST helper rejectOnError config option

Open

#1,293 创建于 2018年10月30日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (3,956 star) (725 fork)batch import
RESTenhancementgood first issue

描述

Just that. How do you feel about a config option for the REST helper to make the promises reject whenever there is an error response, ex. status codes 4XX, 5XX, etc? (I personally think it should be the default behaviour)

I could create a pull request for this, as I have implemented it already on a custom helper on the project I'm working on.

贡献者指南

技术栈
javascriptnodejsrest api
领域
testingbackendapi
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptNode.jsCodeceptJS basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Look at the current REST helper implementation in CodeceptJS, likely in lib/helper/REST.js. Add a config option 'rejectOnError' that defaults to false. When enabled, reject the promise returned by the helper methods (e.g., sendGet, sendPost) if the HTTP response status code is 4xx or 5xx. Ensure the change is backward compatible. Tests should be added for the new option.