cockroachdb/cockroach

docgen: recognize "unimplemented" as marker to ignore rules

开放

#45,464 创建于 2020年2月26日

 (7 条评论) (0 个反应) (0 位负责人)Go (4,124 个派生)batch import
A-docsC-enhancementE-easygood first issue

仓库指标

星标
 (32,150 个星标)
PR 合并指标
 (平均合并 5天 4小时) (30 天内合并 26 个 PR)

描述

Various aspects of our SQL grammar are marked as "unimplemented". These unimplemented features/keywords/etc. should not be included in the generated SQL diagrams we use in our docs. Currently, we must edit diagrams.go to hide unimplemented syntax from the generated bnfs that are used to genereate our SQL diagrams. Instead, it would be great if "unimplemented" were treated like /* SKIP DOC */. This would be much more efficient in that all unimplemented features would be excluded from all generated bnfs without docs writers needed to tweak diagrams.go.

Example: https://github.com/cockroachdb/cockroach/pull/45442

Jira issue: CRDB-5153

贡献者指南