cmu-delphi/forecast-eval

Data downloading fails if score type is coverage or if summarizing across multiple locations

开放

#255 创建于 2023年3月31日

 (0 条评论) (0 个反应) (0 位负责人)R (3 个派生)auto 404
good first issue

仓库指标

星标
 (6 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

We see this error

Warning: Error in filter: Problem while computing `..1 = !is.na(Score) | target_end_date >= filterDate`.
Caused by error in `mask$eval_all_filter()`:
! argument "filterDate" is missing, with no default

filterOverAllLocations requires a filterDate arg, but when totaling across locations or looking at coverage scores, we don't pass filterOverAllLocations a filterDate.

createExportScoreDataFrame will need to be passed at least a date to use in the filter. The value should be dataCreationDate to match other score-generating logic.

Consider passing input$asOf as well and adding as-of data onto the exported dataframe, to more closely match what we're using in the plots.

贡献者指南