cmu-delphi/delphi-epidata

Unit tests (even server unit tests) should not make network calls

开放

#985 创建于 2022年9月28日

 (0 条评论) (0 个反应) (0 位负责人)Python (67 个派生)auto 404
help wantedtests

仓库指标

星标
 (104 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

The following three tests failed when one of our volunteers was trying to run unit tests without having set up the integration test prerequisites. This shouldn't have been a problem, since the point of unit tests is to check the smallest units of functionality, mocking out more complex functions (like network connections).

It's not immediately obvious why these tests were making network calls -- I suspect that something in _common attempts to connect to the database on import.

We should do one of the following:

  • (ideal) figure out how to properly mock out network calls for flask tests
  • (or if that is not possible) move these tests to the integrations section

贡献者指南