cloudtools/stacker

When specifying the tags TLK, stacker removes the stacker_namespace tag

Open

#496 创建于 2017年10月18日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Python (706 star) (166 fork)batch import
enhancementgood first issuehelp wanted

描述

This is more of a bother than a real issue. When a stacker config yaml has tags defined, it removes the default stacker_namespace tag. This is not necessarily the expected behavior.

https://github.com/remind101/stacker/blob/ecd8933d715da8ede5b0d6e6d1e98bd827ff6b43/stacker/context.py#L97

When tackling this issue, we have to be cautious of end-users who have workarounds in place to add the stacker_namespace tag back in via the yaml config. Stacker should not crash in this scenario.

贡献者指南

技术栈
pythonaws
领域
cloudinfrastructure
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
PythonAWS CloudFormation basicsstacker tool usage
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
The bug is in stacker/context.py line 97 where tags are processed. Investigate how the stacker namespace tag is removed when custom tags are specified. Ensure that adding the stacker namespace tag back does not crash existing users with workarounds. Consider adding a test for this behavior.
When specifying the tags TLK, stacker removes the stacker_namespace tag · cloudtools/stacker#496 | Good First Issue