`stacker.util.ensure_s3_bucket` function does not tag S3 buckets created · cloudtools/stacker#495

(5 评论) (0 反应) (0 负责人)Python (706 star) (166 fork)batch import

enhancementgood first issuehelp wanted

描述

Currently S3 buckets created by stacker do not have any tags, even if that bucket is created on a stacker build run with a stacker config yaml defining tags. This is because the ensure_s3_bucket function imported by base and aws_lambda do not submit tags to the function.

We should probably tag the S3 buckets. My concern is not the buckets storing the json templates, but the buckets created for uploads of serverless lambda functions as they could get big and actually have somewhat of an effect on a budget.

So I propose the following...

We modify the function to tag S3 buckets based on the tags top level keyword
We create a new argument in the aws_lambda.upload_lambda_functions function to allow an override, in case an end-user wants to specify a different set of tags for the S3 bucket created by aws_lambda.py:493

I think this should cover all bases as to cost tags that may be required by businesses using stacker.

贡献者指南

技术栈: pythonaws
领域: infrastructuredevops
议题类型: feature
难度: 3
预计时间: 1-2 days
活动状态: stale
清晰度: clear
前置要求: Basic understanding of PythonAWS S3 taggingFamiliarity with Stacker's codebase structure
新手友好度: 45
研究方向: The issue identifies two functions to modify: `ensure s3 bucket` in `stacker/util.py` and `upload lambda functions` in `stacker/aws lambda.py` (line 493). The proposed solution involves adding tag support based on the top level `tags` keyword from the stacker config. Review existing tests for bucket creation and consider adding a new argument for tag override. The issue has 5 comments; check those for further discussion on implementation details.