cloudflare/pingora

Pingora-core L4 listen fail(windows)

Open

#468 创建于 2024年11月12日

在 GitHub 查看
 (4 评论) (0 反应) (1 负责人)Rust (26,634 star) (1,642 fork)batch import
bughelp wanted

描述

Describe the bug

Pingora-core L4 listen fail: cannot find value listen_addr in this scope.

 #[cfg(windows)]
    pub async fn listen(self) -> Result<ListenerEndpoint> {
        Ok(ListenerEndpoint {
            listen_addr,
            listener: bind(&listen_addr).await?,
        })
    }

https://github.com/cloudflare/pingora/blob/main/pingora-core/src/listeners/l4.rs#L308

Pingora info

Please include the following information about your environment:

Pingora version: bdb13a7e40b19280d703ad1f64abc29ee5baf480 Rust version: cargo 1.82.0 Operating system version: e.g. Ubuntu 22.04, Debian 12.4

Steps to reproduce

Please provide step-by-step instructions to reproduce the issue. Include any relevant code snippets.

Expected results

What were you expecting to happen?

Observed results

What actually happened?

Additional context

What other information would you like to provide? e.g. screenshots, how you're working around the issue, or other clues you think could be helpful to identify the root cause.

贡献者指南

技术栈
rust
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Rust basicsunderstanding of conditional compilation
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
The bug is in `pingora core/src/listeners/l4.rs` at line 308, where the Windows specific `listen` function tries to return `listen addr` which is not defined. The fix likely involves either passing `listen addr` as a parameter or recreating the socket address from the listener. Look at the Unix implementation for reference.