Keeping timers relative to start of tunnel initiation is confusing · cloudflare/boringtun#309

(5 评论) (0 反应) (0 负责人)Rust (4,849 star) (321 fork)batch import

code qualitygood first issue

描述

Keeping timers this way means that for example update_session_timers takes a time_now param that's a Duration instead of an Instant. All entries in Tunn::timers are Durations when many of them are "the time that something happened" and idiomatically I think these would be better expressed as Instants.

贡献者指南

技术栈: rust
领域: backend
议题类型: refactor
难度: 3
预计时间: 1-2 days
活动状态: stale
清晰度: clear
前置要求: Rust Duration/Instant typesboringtun codebase structure
新手友好度: 40
研究方向: The issue proposes reworking the timer system to use `Instant` instead of `Duration` for tracking when events occurred. Specifically, `update session timers` takes a `Duration` parameter for `time now` which should be an `Instant`. The `Tunn::timers` field stores `Duration` values that represent absolute times; these should be changed to `Instant`. The change will affect how timers are calculated relative to the tunnel start. Key files to examine include `tunnel.rs` and any module handling timers. The discussion in the issue may provide further insights on required changes.