citusdata/citus

Use TRUNCATE + COPY FREEZE when copying a shard

Open

#7,403 创建于 2024年1月5日

在 GitHub 查看
 (1 评论) (0 反应) (1 负责人)C (9,388 star) (625 fork)batch import
good first issueperformance

描述

In src/backend/distributed/operations/worker_shard_copy.c file contains our main COPY logic for for shard moves and shard splits. After talking with @DimCitus I realized that we could use the FREEZE option of COPY to reduce the the need for heavy vacuuming after the copy is done. To benefit from the freeze option it's required to truncate the target table in the same transaction as the copy. This is fine for all our (current) use cases, because the target shard has just been created and is thus empty.

What I think is needed to achieve this:

  1. Add the FREEZE option to the COPY command that we generate in ConstructShardCopyStatement
  2. Add the FREEZE option to the list of options created in LocalCopyToShard
  3. Start a transaction in ConnectToRemoteAndStartCopy
  4. Truncate the table in ConnectToRemoteAndStartCopy (before starting the COPY)
  5. End the transaction in ShardCopyDestReceiverShutdown

Apart from the actual implementation this needs tests to see that indeed vacuum is not necessary on the new table after a shard move.

贡献者指南