chroma-core/chroma

[CLN] Break up test_api

开放

#2,586 创建于 2024年7月28日

 (4 条评论) (0 个反应) (1 位负责人)Rust (2,247 个派生)batch import
by-chromacleanupgood first issue

仓库指标

星标
 (27,958 个星标)
PR 合并指标
 (平均合并 1天 16小时) (30 天内合并 80 个 PR)

描述

test_api.py is a legacy of Chroma's launch, and provided some basic initial test coverage. We've continued to add to it as the project has evolved, and it's become a catch-all kitchen sink test file.

In practice a lot of the surface covered in test_api is better covered by our property tests. test_api.py should be broken up into separate files by API / object, and each object test should cover exceptional cases, rather than normal operation.

For example, we should save entropy in the property tests by not having them generate lists of IDs that are shorter than the lists of documents on a Collection.add call, but we should also be testing this path.

贡献者指南