christopherdro/react-native-calendar

Inconsistency in passing value to callbacks

Open

#54 创建于 2016年7月19日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (544 star) (250 fork)batch import
enhancementhelp wanted

描述

I spotted inconsistency in callback values. Namely these: onSwipePrep and onSwipeNext receive moment instance. onDateSelected receives date in plain string format.

Unifying this issue is essentially a breaking change, but it would be nice to be consistent.

贡献者指南

技术栈
react native
领域
mobile
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
familiarity with react native calendar callbacksknowledge of moment.js
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate the callback implementations in the source code to confirm which callbacks return moment instances and which return strings. The issue specifically mentions onSwipePrep, onSwipeNext, and onDateSelected. The fix would involve changing the callbacks to consistently return either moment objects or strings. Since this is a breaking change, consider adding a new prop or version. The repository is deprecated, so contribution may not be merged.