chakra-core/ChakraCore

Chakra failed when build with std:c++latest by msvc on Windows

Open

#6,436 创建于 2020年4月23日

在 GitHub 查看
 (7 评论) (0 反应) (0 负责人)JavaScript (9,000 star) (1,374 fork)batch import
Codebase Qualityhelp wanted

描述

Chakra failed when build with std:c++latest by msvc on Windows. Could you please help take a look at this?

You can repro this issue as the steps below:

  1. git clone -c core.autocrlf=true https://github.com/microsoft/ChakraCore D:\Chakra\src
  2. open a clean VS2019 x86 prompt and browse to D:\Chakra\src
  3. set CL=/std:c++latest
  4. msbuild /m /p:Platform=x86 /p:Configuration=Test /p:WindowsTargetPlatformVersion=10.0.18362.0 Build\Chakra.Core.sln /t:Rebuild

Failures: JsrtContextCore.i JsrtContextCore.i(1558483): error C2220: the following warning is treated as an error JsrtContextCore.i(1558483): warning C4499: 'static': an explicit specialization cannot have a storage class (ignored) JsrtContextCore.i(1558485): warning C4499: 'static an explicit specialization cannot have a storage class (ignored) JsrtContextCore.i(1558487): warning C4499: 'static': an explicit specialization cannot have a storage class (ignored)

贡献者指南

技术栈
cpp
领域
build system
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C++ basicsMSVC compilermsbuildChakraCore build system
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Investigate the warning C4499 reported on lines 1558483-1558487 of JsrtContextCore.i. The fix likely involves adding a pragma to disable the warning around those lines. Check for similar patterns in the codebase. Consider using #pragma warning(push) and #pragma warning(disable: 4499) to suppress the warning for those template specializations. Verify that the fix compiles without errors on Windows with /std:c++latest.
Chakra failed when build with std:c++latest by msvc on Windows · chakra-core/ChakraCore#6436 | Good First Issue