Review feature switches/Remove old always on switches · chakra-core/ChakraCore#6415

(1 评论) (2 反应) (0 负责人)JavaScript (9,000 star) (1,374 fork)batch import

Codebase QualityTaskhelp wanted

描述

ChakraCore contains numerous feature switches that in practise are never used - e.g. there's a switch to disable promises and one to disable proxies etc. Some of these bloat the codebase AND require runtime checks for whether they're enabled or not.

EDIT: we should also consider removing phase/option switches that are never used see #4311 for one example (though in that case it's an always on switch)

We should investigate removing some/several of the older ones that are unlikely to ever be switched off and all associated checks.

Note, see lib/Commmon/ConfigFlagsList.h for all switches as the place to start looking.

edit: The PR ref'd below makes a start at this but there's more to do.

贡献者指南

技术栈: cpp
领域: backendperformance
议题类型: refactor
难度: 4
预计时间: over 1 week
活动状态: stale
清晰度: clear
前置要求: C++ programmingUnderstanding of ChakraCore codebaseFamiliarity with feature flagsBuild system knowledge
新手友好度: 20
研究方向: Start by examining the file lib/Common/ConfigFlagsList.h (noted in the issue) to identify feature switches that are always enabled. For each identified switch, trace its usage across the codebase to find runtime checks that can be removed. The issue references a previous PR that made a start; review that PR for guidance. Additionally, consider removing phase/option switches that are never used as mentioned in #4311. Ensure that removal does not affect the engine's functionality.