chakra-core/ChakraCore

JSRT: JsDeleteIndexedProperty does not tell successful or not

Open

#504 创建于 2016年3月10日

在 GitHub 查看
 (10 评论) (0 反应) (0 负责人)JavaScript (9,000 star) (1,374 fork)batch import
APIsBugSeverity: 3good first issuehelp wanted

描述

JsDeleteIndexedProperty API does not tell if the deletion is successful or not, unlike JsDeleteProperty which returns that info in "result". The former also misses "useStrictRules" flag which exists in the later.

JsDeleteIndexedProperty(JsValueRef object, JsValueRef index)

JsDeleteProperty(JsValueRef object, JsPropertyIdRef propertyId,
                 bool useStrictRules,
                 JsValueRef *result)

These 2 APIs should be comparable and consistent.

贡献者指南

技术栈
cjavascript
领域
api
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C programmingChakraCore API
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Look at the implementation of JsDeleteIndexedProperty and JsDeleteProperty in the ChakraCore source, likely in jsrt.cpp. The goal is to add a 'result' parameter and 'useStrictRules' flag to JsDeleteIndexedProperty, and update its call sites to return success status. Check existing tests for the delete property API to understand expected behavior.