Codebase Qualityhelp wanted
仓库指标
- Star
- (9,000 star)
- PR 合并指标
- (30 天内没有已合并 PR)
描述
I am trying to port ChakraCore to Buck Build, but the include paths used in ChakraCore are making this difficult.
For instance:
RuntimeBasePch.hcontains#include "Runtime.h";Runtime.hcontains#include "../JITIDL/JITTypes.h".
This causes the compiler to walk outside of the top-level of the build, which breaks reproducibility.
This scenario is avoidable if a path without ../ is used instead. For example:
#include "JITIDL/JITTypes.h"
Or better yet, something like this:
#include <ChakraCore/JITIDL/JITTypes.h>
Ideally, all headers would be included from the same include-path. This is common practice is many C++ libraries, such as Boost.
What are the ChakraCore team's thoughts on this?