casesandberg/react-color

Cant type in 4 or 8 letter color names in editable input anymore

Open

#552 创建于 2018年10月19日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)JavaScript (11,679 star) (946 fork)batch import
bughelp wanted

描述

On the react color demo page I am able to type in "blue" into any of the editable inputs and that is recognized as valid. Since this fix - https://github.com/casesandberg/react-color/commit/669bf040955d2b8ff82b491e1044d28fe80d06b5#diff-012ff5a8f8316a2507102ec918eaf81b I am not able to type in 4 or 8 letter color names. They return as invalid because of the length check. So while "red" or "yellow" works fine, "blue" or "gray" doesnt.

Is there a work around for this?

贡献者指南

技术栈
javascriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
familiarity with Reactbasic string validation logic
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
The issue is caused by a commit that added a length check for color names. Examine the commit at https://github.com/casesandberg/react color/commit/669bf040955d2b8ff82b491e1044d28fe80d06b5 and locate the helper function that validates color names (likely in src/helpers/). The current check rejects names with lengths other than 3, 5, 6, or 7, but should allow any length (e.g., 4 for 'blue', 8 for 'gray'). To fix, remove or modify the length validation to accept all valid CSS color names. No existing PR or assignee, so it's open for contribution.