casesandberg/react-color

Photoshop HSV up/down arrow controls are not working correctly

Open

#385 创建于 2017年7月23日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (11,679 star) (946 fork)batch import
help wanted

描述

When using arrow up/down keys on the (S)aturation field, the Value fields jumps to 0. After this, losing focus of the Saturation field will have it jump back to 0 too, because the Value is 0 and the actual color value updates the color picker. You can see the docs page to confirm this.

贡献者指南

技术栈
javascriptreacthtmlcss
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Reactfamiliarity with color models
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Examine the Photoshop color picker component in `src/components/photoshop/Photoshop.js`. The bug is related to HSV input fields. Look at how the `Saturation` and `Value` fields interact with keyboard events. The issue reports that using arrow up/down on Saturation causes Value to jump to 0 and losing focus reverts it. Consider adding proper state updates and validation to prevent the Value from being incorrectly set to 0 when Saturation changes. There are no linked PRs or comments, so the fix is open. Ensure that the color conversion functions in `src/helpers/color.js` are correctly used.