casesandberg/react-color

Wrong Brightness Coefficients

Open

#184 创建于 2016年7月2日

在 GitHub 查看
 (11 评论) (0 反应) (0 负责人)JavaScript (11,679 star) (946 fork)batch import
bughelp wanted

描述

https://github.com/casesandberg/react-color/blob/master/modules/tinycolor2/index.js#L76

For now there are coefficients for NTSC, not sRGB. And i think that w3c is little bit outdated.

Also see this demo: http://codepen.io/dom1n1k/pen/LZWjbj

See sRGB table: http://www.brucelindbloom.com/index.html?WorkingSpaceInfo.html Or point 9 here: http://www.poynton.com/notes/colour_and_gamma/ColorFAQ.html

贡献者指南

技术栈
javascript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
JavaScriptcolor theory basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The issue points to wrong brightness coefficients in the tinycolor2 module at modules/tinycolor2/index.js line 76. The current coefficients are for NTSC, but should be sRGB coefficients. The user provides references to sRGB coefficients from Bruce Lindbloom and Poynton. To fix, replace the coefficient values in the luminance calculation with correct sRGB values. Ensure the change matches the expected output from the demo link. No linked PRs exist.
Wrong Brightness Coefficients · casesandberg/react-color#184 | Good First Issue