carla-simulator/carla

port(streaming): ServerSession::CloseNow idempotency fix to ue5-dev

已关闭

#9,759 创建于 2026年5月27日

在 GitHub 查看
 (0 条评论) (0 个反应) (0 位负责人)C++ (3,227 个派生)batch import
Good community contribgood first issue

仓库指标

星标
 (10,105 个星标)
PR 合并指标
 (平均合并 17天 10小时) (30 天内合并 21 个 PR)

描述

Context

PR #9740 fixed a double-close race in ServerSession::CloseNow() on ue4-dev when two async paths (deadline timer + a failing write) both triggered a close for the same session, _on_closed() -> DisconnectSession() was called twice, silently evicting a still-alive subscriber from the world-snapshot stream.

The fix adds std::atomic_bool _is_closed{false} to ServerSession and guards CloseNow() with _is_closed.exchange(true) so the close path runs exactly once.

Task

Port the fix from ue4-dev to ue5-dev.

Files to update:

  • LibCarla/source/carla/streaming/detail/tcp/ServerSession.h
  • LibCarla/source/carla/streaming/detail/tcp/ServerSession.cpp

References

  • Fix: #9740

贡献者指南

研究方向
Review PR #9740 on ue4 dev to understand the double close race fix. Then apply the same changes to ue5 dev: add `std::atomic bool is closed{false}` to ServerSession.h and guard `CloseNow()` with ` is closed.exchange(true)` in ServerSession.cpp. Verify no branch specific differences affect the fix.
技术栈
cpp
领域
backend
议题类型
缺陷
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1 小时以内
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
新近可参与
清晰度议题是否清楚说明期望改动、验收标准和下一步。
清晰
前置要求
C++atomic operationsCARLA streaming subsystem
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85