canonical/multipass

[snapshot] Lack of interactive stdin causes unhandled exception on `multipass restore`

Open

#4,825 创建于 2026年4月15日

在 GitHub 查看
 (1 评论) (0 反应) (1 负责人)C++ (6,956 star) (634 fork)batch import
buggood first issuelowlow hanging fruit

描述

Describe the bug I am trying to restore the state of a VM without interactive stdin. If the --destructive flag is not used, it results in an unhandled exception.

└─[2] echo "no" | multipass stop a             
└─[λ] echo "no" | multipass restore a.snapshot1
[2026-04-15T17:44:54.113] [error] [client] Caught an unhandled exception: Unable to query client for confirmation. Use '--destructive' to automatically discard current machine state.

To Reproduce How, and what happened?

  1. multipass launch -n a && multipass stop a
  2. multipass snapshot a
  3. echo "no" | multipass restore a.snapshot1

Expected behavior Multipass should handle the exception and output the error message to the user.

Additional info

  • OS: Ubuntu 24.04 (authd)
  • CPU architecture or model: amd64
  • multipass version: 1.17.0-dev

贡献者指南

技术栈
cpp
领域
cli
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic C++ knowledgeUnderstanding of CLI stdin handling
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Examine the multipass restore command implementation in the client code (likely in src/client/ directory). The error 'Unable to query client for confirmation' suggests a missing check when stdin is not interactive. Look for where user confirmation is requested and handle the non interactive case gracefully, as done with destructive flag. The fix should catch the exception and output the error message instead of aborting.