canonical/multipass

Fix spinner for non-interactive use

Open

#1,541 创建于 2020年5月15日

在 GitHub 查看
 (9 评论) (0 反应) (0 负责人)C++ (6,956 star) (634 fork)batch import
enhancementhelp wantedlow hanging fruitmedium

描述

Attempting to run non-interactive scripts that run multipass. Logs look like this:

Creating VMs...

                                                                                

                                                                                
Creating test-0  / 
                                                                                

                                                                                
Configuring test-0  /- 
                                                                                

                                                                                
Starting test-0  /-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\ 
                                                                                

                                                                                
Waiting for initialization to complete  /-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\| 
                                                                                
Launched: test-0

                                                                                
Created VM test-0.

This could be resolved by disabling spinners when not running on a live terminal, or via switch.

贡献者指南

技术栈
cppshell
领域
cli
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Basic C++ knowledgeUnderstanding of terminal capabilities
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
The issue describes messy spinner output in non interactive contexts. To fix, you need to detect whether the terminal is interactive using functions like isatty() or checking the terminal type. The relevant code is likely in the spinner implementation, which shows characters like backspaces. Look for files related to progress indicators or console output, such as those in src/utils/ or src/ssh/. There are 9 comments but no linked PRs; check if any prior attempts exist. The fix should disable spinner animation when not on a live terminal, possibly via a switch or environment variable.