canonical/charming-actions

`upload-charm` should catch and raise on empty credentials

开放

#42 创建于 2022年6月3日

 (1 条评论) (0 个反应) (1 位负责人)TypeScript (28 个派生)auto 404
Type: Buggood first issue

仓库指标

星标
 (9 个星标)
PR 合并指标
 (30 天内没有已合并 PR)

描述

The Kubeflow team had CI using this action recently fail when executed from a fork. We believe this is because the fork did not define the credentials secret, thus meaning the credentials argument passed to upload-charm was an empty string.

Assuming this is the correct failure mode, upload-charm should catch and fail with an obvious error when it is passed blank or obviously incorrect credentials. Calling the action with an empty credential is an especially easy error to make in github actions, as actions will silently use an uninstantiated variable rather than raise an error.

贡献者指南