cake-build/cake

Tool.Run should make stdout and stderr available on failure

Open

#2,460 创建于 2019年1月24日

在 GitHub 查看
 (4 评论) (2 反应) (0 负责人)C# (3,742 star) (738 fork)batch import
Help wantedImprovementUp-for-grabs

描述

Tool.Run and related should make stdout and stderr available so that some analysis is possible on failure. Currently it calls ProcessExitCode which throws a simple CakeException.

Ideally, it would capture stdout and stderr and throw a CakeProcessException, or similar, that has additional properties for exit code, stdout and stderr.

贡献者指南

技术栈
csharp
领域
build systemtooling
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C#Cake build system basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
The request is to modify the Tool.Run method in src/Cake.Core/Tooling/Tool.cs to capture stdout and stderr before throwing an exception. Currently, at line 119, ProcessExitCode is called, and at line 139, a simple CakeException is thrown. The improvement is to create a new exception class CakeProcessException that includes exit code, stdout, and stderr. The implementation should capture the standard output/error from the process. A suggested approach is to use ProcessStartInfo.RedirectStandardOutput and RedirectStandardError before starting the process, then read the output streams before checking the exit code. The new exception should be thrown instead of CakeException. This is a well defined change with concrete file references.