cake-build/cake

CleanDirectories does not handle cleaning directories with symlinks without unnecessary errors

Open

#2,135 创建于 2018年4月23日

在 GitHub 查看
 (1 评论) (2 反应) (0 负责人)C# (3,742 star) (738 fork)batch import
BugHelp wantedUp-for-grabs

描述

What You Are Seeing?

This error

An error occurred when executing task 'Default'.
Error: One or more errors occurred.
	Could not find a part of the path '/Users/donblas/tmp/cake/example/fsharp-macos.framework/Versions/Current'.

when cleaning directories of a certain structure.

What is Expected?

It to clean without error.

What version of Cake are you using?

$ mono .cake/Cake/Cake.exe --version | tail -n 2 Version 0.27.1+Branch.main.Sha.7e44aa0319b6ef12ecc415d79a1c75cc98e2c788

Are you running on a 32 or 64 bit system?

64-bit

What environment are you running on? Windows? Linux? Mac?

macOS

Are you running on a CI Server? If so, which one?

Reproduces without.

How Did You Get This To Happen? (Steps to Reproduce)

clean_bug.zip

  1. Download attached zip file
  2. Copy fsharp-macos.framework from the backup folder to example
  3. ./build.sh

Output Log

Diag: https://gist.github.com/chamons/3def1b016716b71beb2365a322ba2513 Diag w\ mono: https://gist.github.com/chamons/858cdcca2266a6afb796fa4ba4a108fa --verbosity diagnostic -mono -Experimental: https://gist.github.com/chamons/b9248c9d30c167c679fd4b3b3d56f81a

贡献者指南

技术栈
csharp
领域
build system
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Basic knowledge of C#Understanding of symlinks
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
55
研究方向
Investigate the CleanDirectories implementation in the Cake build system (likely in src/Cake.Core/IO/DirectoryCleaner.cs or similar). The issue is that cleaning a directory containing symlinks (e.g., a macOS framework) throws a 'Could not find a part of the path' error. The fix should ensure that symlinks are properly followed or skipped during directory traversal. Start by reproducing the bug with the provided zip file, then examine how Directory.Delete handles symlinks on macOS. A possible solution is to use Directory.EnumerateFileSystemEntries with appropriate options or handle the case where a symlink target does not exist by skipping it.