cake-build/cake

CopyFiles does not respect folder structure when pattern only matches files in a subdirectory

Open

#2,102 创建于 2018年3月26日

在 GitHub 查看
 (2 评论) (1 反应) (0 负责人)C# (3,742 star) (738 fork)batch import
BugHelp wantedUp-for-grabs

描述

What You Are Seeing?

CopyFiles does not correctly respect the folder structure when a pattern is used which only matches files in a subdirectory.

What is Expected?

If I have the files: ./src/file1.txt ./src/sub/file2.txt ./src/sub/file3.dat

The command CopyFiles("./src/**/*.txt", "./dest", true) will result in: ./dest/file1.txt ./dest/sub/file2.txt

However the command CopyFiles("./src/**/*.dat", "./dest", true) will result in: ./dest/file3.dat

I would expect it to result in: ./dest/sub/file3.dat

What version of Cake are you using?

0.26.1

Are you running on a 32 or 64 bit system?

64bit

What environment are you running on? Windows? Linux? Mac?

Windows

Are you running on a CI Server? If so, which one?

No

How Did You Get This To Happen? (Steps to Reproduce)

This repo demonstrates the issue: https://github.com/dandezille/cake-copyfiles

Output Log

https://gist.github.com/dandezille/f34f8f0c0fc8429be8fe85397c588856

贡献者指南

技术栈
csharp
领域
build systemtooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C# basicsCake build system basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
The bug is in the CopyFiles method. The issue provides a minimal repo (https://github.com/dandezille/cake copyfiles) to reproduce the problem. Examine the implementation of CopyFiles in the Cake source code, specifically how directory structure is preserved when the pattern only matches files in subdirectories. The expected behavior is that the directory hierarchy relative to the source should be maintained in the destination. Check if the issue is in the pattern matching or directory creation logic. Look at existing tests for CopyFiles to understand expected behavior.