byt3bl33d3r/CrackMapExec

Logging discrepancies ?

Open

#534 创建于 2022年2月6日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Python (7,931 star) (1,650 fork)batch import
help wanted

描述

Hey there, I was working on the source code of the ldap protocol (cme/protocols/ldap.py) and was wondering why some debug logging is made with self.logger.info and why other is made with logging.debug.

https://github.com/byt3bl33d3r/CrackMapExec/blob/6e57e4c3616b361fa44311389af2bbd7bb12839c/cme/protocols/ldap.py#L509

https://github.com/byt3bl33d3r/CrackMapExec/blob/6e57e4c3616b361fa44311389af2bbd7bb12839c/cme/protocols/ldap.py#L533

Is there a best practice to follow, which one should we use?

贡献者指南

技术栈
python
领域
developer experience
议题类型
research
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
1
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Python basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
90
研究方向
Examine the usage of self.logger.info vs logging.debug in the ldap.py file at lines 509 and 533. Review other protocol files in cme/protocols to see which logging style is more common. If inconsistent, propose a consistent approach (e.g., use self.logger for all debug logging) and update the file accordingly. The change is localized and should not affect functionality.