browsh-org/browsh

Kill the headless Firefox process by PID, not by grepping `ps`

Open

#61 创建于 2018年7月9日

在 GitHub 查看
 (2 评论) (3 反应) (0 负责人)JavaScript (15,996 star) (455 fork)batch import
enhancementhelp wanted

描述

This was first brought up by a user that had an existing Selenium session: #59

If Browsh's Firefox process can have an identifying mark to it, then we can detect that instead of a crude detection of any headless Firefox process.

贡献者指南

技术栈
javascript
领域
cli
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Basic Node.jsUnderstanding of child processesFamiliarity with Firefox CLI flags
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Look at how Browsh currently launches Firefox, likely in the browser launcher code. Understand the current method of killing by grepping ps and the issue referenced (#59). Implement a unique identifier (e.g., a custom command line argument like ' browsh pid') to be passed to Firefox, so the process can be killed by PID directly. Ensure the identifier is stored and retrievable after spawning.
Kill the headless Firefox process by PID, not by grepping `ps` · browsh-org/browsh#61 | Good First Issue