brave/brave-browser

The keyboard layout is wrong when defining a shortcut

Open

#47,764 创建于 2025年7月19日

在 GitHub 查看
 (0 评论) (3 反应) (0 负责人)JavaScript (16,194 star) (2,164 fork)batch import
OS/DesktopOS/Linuxfeature/keyboard-shortcutshelp wantedpriority/P5

描述

Description

when defining a now shorcut, brave seems to use a querty layout, while my keyboard is azerty

Steps to reproduce

  1. add a new shortcut
  2. tap a key combinaison (example ctrl + a)

Actual result

ctrl + q is shown on the screen

Expected result

ctrl + a should be shown instead

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.80.122 Chromium: 138.0.7204.157 (Build officiel) (64 bits) Révision d9aff5c5def33bd27a6ae282e7b3e90e9bd9cfa2 Système d'exploitation Linux

(flatpak)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

贡献者指南

技术栈
javascriptcpp
领域
frontendlocalization
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic JavaScriptfamiliarity with keyboard events
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Investigate the shortcut definition UI in Brave's frontend code, likely in files under `app/` or `components/` that handle keyboard event capturing. Look for where key events are mapped to display strings. The issue is that the current implementation assumes QWERTY layout. Test with AZERTY layout on Linux. Consider using `event.code` vs `event.key`; the former is layout independent. A fix might involve using `event.code` for display or detecting the keyboard layout. Check existing Chromium issues for similar bugs.
The keyboard layout is wrong when defining a shortcut · brave/brave-browser#47764 | Good First Issue