brave/brave-browser

Show BAT favicon when adding rewards internal page to sidebar

Open

#41,617 创建于 2024年10月14日

在 GitHub 查看
 (5 评论) (0 反应) (1 负责人)JavaScript (16,194 star) (2,164 fork)batch import
OS/Desktopfeature/settingsfeature/sidebargood first issuepriority/P5

描述

When adding the rewards internal page to the sidebar, the icon doesn't appear and instead shows an "R". We should change the icon that shows so it shows the correct BAT icon

Figma https://www.figma.com/design/H11ZOl6JMYbCTW4ZJXqR5V/%F0%9F%A6%81-Browser?node-id=8165-19398&t=5wWBqB0CO1rtctLm-1

Actual result

Image

Expected result

Image

贡献者指南

技术栈
javascriptcssreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic React knowledgefamiliarity with Brave UI components
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Review the Brave sidebar code for adding internal pages. The icon for the rewards page is currently a placeholder 'R'. The Figma design (linked) shows the correct BAT icon. Locate where the sidebar item icon is set and replace it with the appropriate BAT icon asset. Check existing icon assets in the repository for the BAT icon.