brave/brave-browser

[Android] Update button on filters page should update all lists including custom lists

Open

#39,431 创建于 2024年6月27日

在 GitHub 查看
 (2 评论) (0 反应) (1 负责人)JavaScript (2,164 fork)batch import
OS/Androidfeature/componentsfeature/settingsgood first issuepriority/P4

仓库指标

Star
 (16,194 star)
PR 合并指标
 (平均合并 4小时 38分钟) (30 天内合并 19 个 PR)

描述

Description

We currently don't update the custom filter lists via the Update button introduced in https://github.com/brave/brave-browser/issues/35270. On Desktop, it's fairly clear that the Update button will update the non-custom-lists (default + additional) because it's tied to that section, but on Android the Update button is at the top and directly above the Custom section.

To summarize the changes:

  1. no changes to the Update button text
  2. we simply start updating the custom filter lists as well
  3. for the text that pops up when you press the button, we say “All lists" instead

Steps to reproduce

On Android, go to Content filters in Settings > Brave Shields & privacy Try to press the update button

Actual result

Custom lists not updated

Expected result

Custom lists should be updated

Reproduces how often

Easily reproduced

Brave version

1.68

Device

See https://github.com/brave/brave-core/pull/23929

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

贡献者指南