bottlerocket-os/twoliter

Improve `docker-go` interface

开放

#492 创建于 2022年10月28日

 (0 条评论) (1 个反应) (0 位负责人)Rust (43 个派生)auto 404
help wanted

仓库指标

星标
 (34 个星标)
PR 合并指标
 (平均合并 4天 18小时) (30 天内合并 19 个 PR)

描述

The only safe way to use docker-go is to pass a single argument to --command. Anything else would lead to unexpected behavior, for example docker-go --command foo bar baz is indistinguishable from docker-go --command foo 'bar baz' and docker-go --command foo --module-path bar will both pass --module-path bar to foo, and actually modify the script's GO_MODULE_PATH variable.

Is it feasible to change the script's interface without too many coordinated changes? A safer interface could interpret anything after -- as the command to execute, and keep all following arguments in an array (COMMAND=( "$@" ), later: "${COMMAND[@]}") to retain fidelity of the originally passed-in arguments.

Originally posted by @markusboehme in https://github.com/bottlerocket-os/bottlerocket/pull/2532#discussion_r1007948798

贡献者指南