仓库指标
- Star
- (181 star)
- PR 合并指标
- (PR 指标待抓取)
描述
Some recent user feedback reminded me that #450 got implemented without support for logo images, which is necessary for some users for branding purposes.
Copying relevant comments from the initial issue:
... there is an online converter of SVG files to the ass format drawing commands, although it may be worth rolling our own, or at least including options for scaling and a position offset.
It could also be valuable to make/recommend a raster -> vector image converter that's focused on logos, since that's what we're expecting people to want to display, and users may not have a nice vector source already.
It could be cool to have an optional Cockpit logo in the top right corner, and possibly also logo options for the autopilot firmwares (e.g. ArduSub, ArduPilot, PX4, etc)
This may be technically possible already via a janky workaround of pasting the relevant ass drawing commands into a data lake variable, but that's not nicely exposed to users, and would require lots of manual trial and error to get a reasonable result. It is of course possible for the user to just edit the subtitle file themselves and paste in the relevant drawing commands, but that's cumbersome to do for multiple subtitle files, and Cockpit should be able to ease that burden.
I think we should aim to have one optional logo displayed for the entire duration of the subtitles (e.g. 0:00:00.00 to 99:59:59.99), which is only specified once, at the start of the subtitles. At minimum the user should have a text box to paste the drawing commands into, but ideally they could just upload an SVG and specify its size and location in the subtitle file.