blue-oil/blueoil

View class in dlk should be merge into Operator classes

Open

#478 创建于 2019年10月2日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)Python (250 star) (85 fork)batch import
good first issue

描述

View.run method in view.py is quite long. It is actually just returning stringified C++ source code for each operator. Hence, it looks very natural to decompose this method and merge the pieces into each corresponding operators implementation in operator.py.

After the merge, we will be able to remove View class.

贡献者指南

技术栈
python
领域
backendmachine learning
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic Python programmingfamiliarity with blueoil codebase
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
The issue aims to refactor the View class in view.py by decomposing its run method and merging the pieces into the corresponding operator implementations in operator.py. After the merge, the View class can be removed. The contributor should study the View.run method to understand how it generates C++ source code for each operator, then move that logic into the respective operator classes. This involves code reorganization and ensuring no functionality is broken.