blakeembrey/code-problems

Broken tests?

Open

#118 创建于 2014年6月3日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (3,818 star) (586 fork)batch import
help wanted

描述

TDD is something I have to take a deeper look, but the tests at least for python are broken. It failed because the test can't find the methods used, which is normal because they aren't imported.

python largest-continuous-sum.py
E
======================================================================
ERROR: test_largest_continuous_sum (__main__.LargestContinousSequenceTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "largest-continuous-sum.py", line 5, in test_largest_continuous_sum
    sum = largest_continuous_sum([1, 2, 3, 4])
NameError: global name 'largest_continuous_sum' is not defined

----------------------------------------------------------------------
Ran 1 test in 0.000s

As this is not a package, how we should accomplish this?

贡献者指南

技术栈
python
领域
testing
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
1
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic Pythontesting knowledge
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
95
研究方向
The issue points to the file 'largest continuous sum.py' in the repository 'blakeembrey/code problems'. The test method 'test largest continuous sum' fails because 'largest continuous sum' is not defined or imported. The fix is to import or define the function 'largest continuous sum' in the test file. Check if there is a separate implementation file and import it, or define the function in the same file.
Broken tests? · blakeembrey/code-problems#118 | Good First Issue