bitwarden/server

"Create Account" Button should be inactive/hidden when "globalSettings__disableUserRegistration=true"

Open

#1,268 创建于 2021年4月11日

在 GitHub 查看
 (11 评论) (6 反应) (1 负责人)C# (18,588 star) (1,575 fork)batch import
enhancementgood first issue

描述

Hi everyone,

The topic is not entirely new and an attempt has already been made to address it with issue #631 . Unfortunately the task was closed.

But I would still be of the opinion that it would make sense to deactivate the "Create Account" button and hide it as soon as the config option globalSettings__disableUserRegistration is set to "true".

At the moment it is possible to enter all data including email, username and password and only on submitting the register form user gets an error toast. This is somehow unnecessary and also arouses false expectations among users

贡献者指南

技术栈
csharphtmlcss
领域
frontendauthentication
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C#HTMLCSS
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate how the config option 'globalSettings disableUserRegistration' is used in the server code. Look for the registration view or controller that renders the 'Create Account' button. Check the previous attempt #631 for context. The change likely involves conditionally hiding the button in the view based on the config value.