bitwalker/timex

Most functions are incorrect for calendars other than Calendar.ISO

Open

#449 创建于 2018年7月30日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Elixir (1,807 star) (406 fork)batch import
feature/enhancementhelp wantedlevel:advanced

描述

Most functions in Timex manipulate the Elixir data structures directly. In doing so, they assume a lot about the underlying calendar - in most cases the functions would just not work for anything other than Calendar.ISO. The prime example would be Timex.shift/2.

Timex should either amend those functions to be correct in case they are called with other calendars, or pattern match on the value and document the functions to only work with Calendar.ISO.

贡献者指南

技术栈
elixir
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ElixirTimex libraryCalendar module
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
Examine the Timex source code to identify which functions manipulate Elixir data structures directly and assume ISO calendar. Focus on `Timex.shift/2` and similar functions. Check the documentation to see if there are existing guards or pattern matches. Decide whether to add calendar aware implementations or restrict to ISO and update docs accordingly. Consider looking at the `Calendar` module in Elixir for guidance on supporting multiple calendars.