bitovi/funcunit

Dynamic iframes are considered not loaded

Open

#139 创建于 2016年2月24日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (575 star) (395 fork)batch import
bughelp wantedp2

描述

If I create an <iframe>, populate it dynamically, and set it as the context for FuncUnit like this:

var iframe = $(document.createElement('iframe'));
iframe.contents().find('body').append(frag);    
F.open(win);

All tests will fail because FuncUnit.documentLoaded() will return false here: https://github.com/bitovi/funcunit/blob/01f767b1e95737a7dfcae1f67a75b4d72408ba37/browser/getters.js#L509

Due to the fact that FuncUnit.win.location.href === 'about:blank' here: https://github.com/bitovi/funcunit/blob/92fd4b283388576922506fb76096902c8f9183bf/browser/open.js#L258-L260

To get around this I had to overwrite FuncUnit.documentLoaded to always return true like this:

F.documentLoaded = function () { return true; };

贡献者指南

技术栈
javascript
领域
testing
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic understanding of FuncUnitJavaScript
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate the logic in FuncUnit's open.js at lines 258-260 where it checks if win.location.href === 'about:blank'. Then examine documentLoaded in getters.js at line 509. The bug is that dynamic iframes with 'about:blank' are not considered loaded. Consider modifying the check to handle dynamically created iframes, perhaps by adding a flag or checking the document's readyState. The issue includes a workaround that forces documentLoaded to always return true; a proper fix should distinguish between loaded and unloaded states.