benoitc/gunicorn

`reload_extra_files` should accept wildcards

Open

#1,643 创建于 2017年11月14日

在 GitHub 查看
 (5 评论) (14 反应) (0 负责人)Python (9,334 star) (1,707 fork)batch import
Feature/Reloadgood first issue

描述

Hi,

My app structure is such that each view in my app has it's own config.json located at ui/<view_name>/config.json.

I would love to reload on modification for each of those JSON files.

Currently, I'm doing, for each view:

reload_extra_file = [
  'ui/<view_1>/config.json',
  'ui/<view_2>/config.json',
  'ui/<view_3>/config.json,
  ...
]

but this is a little cumbersome, since I have to add a new line everytime I add a view to my app (and I tend to forget about it).

We should support wildcards for this kind of use case, something like:

reload_extra_file = ['*.json', '*.js', '*.py', '*.yaml']

@benoitc Is that something you would consider implementing ? I can maybe help with this and create a PR if you let me know where this needs to be changed in the current code.

贡献者指南

技术栈
python
领域
backend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
gunicorn configurationPythonglob patterns
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
The issue requests adding wildcard/glob support to the `reload extra files` configuration option. A good starting point is to examine how gunicorn currently handles `reload extra files` in its configuration parsing (likely in `gunicorn/config.py` or similar) and the file reloading mechanism (e.g., in `gunicorn/reloader.py`). Implement support for glob patterns using Python's `glob` module or `fnmatch`. The issue comments (https://github.com/benoitc/gunicorn/issues/1643) contain discussion and may include guidance from the maintainer on where to make changes.