benoitc/gunicorn

Separate instrumentation and logging

Open

#1,564 创建于 2017年8月6日

在 GitHub 查看
 (9 评论) (4 反应) (0 负责人)Python (9,334 star) (1,707 fork)batch import
Feature/LoggingImprovementhelp wanted

描述

Issues like #1405 demonstrate that having statsd instrumentation built on top of the logging handlers means instrumentation and logging are coupled. Some have found this coupling surprising.

I would like to see proposals for ways to separate these functions.

This may be as simple as making the statsd Logger into a handler instead, so it can be invoked no matter which logger is being used.

贡献者指南

技术栈
python
领域
backendobservability
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
basic understanding of gunicorn
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
The issue requests a design to decouple statsd instrumentation from logging handlers in gunicorn. A starting point is to examine the existing statsd integration in gunicorn's handlers (e.g., 'gunicorn.instrument.statsd') and the logging configuration in 'gunicorn.glogging'. The discussion in comments suggests converting the statsd Logger into a separate handler. You should review the referenced issue #1405 and explore the codebase to understand current coupling before proposing a solution.
Separate instrumentation and logging · benoitc/gunicorn#1564 | Good First Issue