beautifier/js-beautify

Option unescape_strings can produce invalid string literals making JS invalid/uninterpretable

Open

#2,141 创建于 2023年3月17日

在 GitHub 查看
 (9 评论) (0 反应) (0 负责人)JavaScript (8,342 star) (1,460 fork)batch import
good first issuelanguage: javascripttype: bug

描述

Description

Option unescape_strings can produce invalid string literals making JS invalid/uninterpretable

Input

The code looked like this before beautification:

        function () {
          i.exports = "\t\n\x0B\f\r   ᠎             　\u2028\u2029\ufeff"
        }()

Expected Output

The code should have looked like this after beautification: code that does not contain invalid string literals

Actual Output

The code actually looked like this after beautification:

        function () {
          i.exports = "\t\n\x0B\f\r   ᠎             　

"
        }()

Steps to Reproduce

Environment

OS: Firefox/Win10

Settings

{
        "unescape_strings": true,
}

贡献者指南

技术栈
javascriptnodejs
领域
tooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic JavaScriptUnderstanding of string escaping
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
The bug is in the 'unescape strings' option of js beautify. Look at the code in lib/beautifier.js or src/js/beautifier.js to see how unescaping is implemented. The issue is that certain Unicode characters like line separators are being converted to actual newlines, breaking the string literal. Investigate the regex or string replacement logic that handles escaped sequences, and ensure that only intended escape sequences are unescaped without introducing invalid literals. Check the existing test files for string handling to understand expected behavior.