beautifier/js-beautify

Beautification problem with JS Single Line Comment <!--

Open

#1,835 创建于 2020年8月31日

在 GitHub 查看
 (9 评论) (0 反应) (1 负责人)JavaScript (8,342 star) (1,460 fork)batch import
good first issuelanguage: javascripttype: bug

描述

In Javascript <!-- is treated as a single-line comment just like //.

js-beautify works as expected when the line starts with <!--:

Input: <!--alert(1)commented

Output: <!--alert(1)commented

Otherwise it will break the syntax:

Input: alert(1)<!--commented

Output: alert(1) < !--commented

贡献者指南

技术栈
javascript
领域
tooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic understanding of JavaScript parsing
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Investigate the tokenizer or comment handling in js beautify, likely in files like 'js/index.js' or 'core/tokenizer.js'. The issue occurs when `<! ` is not at the start of a line, so the regex or logic that identifies single line comments might need to be extended to include `<! ` as a comment starter. Look at how `//` is handled and add similar handling for `<! `. Check existing tests for comment handling and write a failing test for this case.
Beautification problem with JS Single Line Comment <!-- · beautifier/js-beautify#1835 | Good First Issue